openssl: Fix openssl_pkcs12_export extracerts test #2681
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpunt
reviewed
Aug 14, 2017
| @@ -42,6 +42,7 @@ bool(true) | |||
| bool(true) | |||
| bool(true) | |||
| bool(true) | |||
| int(3); | |||
There was a problem hiding this comment.
The additional semicolon here causes this test to fail.
There was a problem hiding this comment.
Woops, fixed it with an amend.
jelly
force-pushed
the
openssl_pkcs12_export_fix_test
branch
3 times, most recently
from
1c8b64f to
2b4824c
Compare
Fix the openssl_pkcs12_export testcase for extracerts, the 'extracerts' option needs to be the key of the certificate value otherwise openssl_pkcs12_export will ignore it.
jelly
force-pushed
the
openssl_pkcs12_export_fix_test
branch
from
2b4824c to
ba63672
Compare
|
Anything holding this PR up from getting merged? |
|
Comment on behalf of bukka at php.net: Merged via 314bef5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the openssl_pkcs12_export testcase for extracerts, the 'extracerts'
option needs to be the key of the certificate value otherwise
openssl_pkcs12_export will ignore it.